fix: The block_duration_minutes attribute under launch template spot_options is not a required
#1847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… not a required attribute
bryantbiggs
changed the title
block_duration_minutes under launch template spot_options is not a required attributeblock_duration_minutes attribute under launch template spot_options is not a required
antonbabenko
pushed a commit
that referenced
this pull request
Feb 4, 2022
### [18.3.1](v18.3.0...v18.3.1) (2022-02-04) ### Bug Fixes * The `block_duration_minutes` attribute under launch template `spot_options` is not a required ([#1847](#1847)) ([ccc4747](ccc4747))
|
This PR is included in version 18.3.1 🎉 |
agconti
reviewed
Feb 15, 2022
| @@ -158,7 +158,7 @@ resource "aws_launch_template" "this" { | |||
| dynamic "spot_options" { | |||
| for_each = lookup(instance_market_options.value, "spot_options", null) != null ? [instance_market_options.value.spot_options] : [] | |||
| content { | |||
| block_duration_minutes = spot_options.value.block_duration_minutes | |||
| block_duration_minutes = lookup(spot_options.value, block_duration_minutes, null) | |||
There was a problem hiding this comment.
@antonbabenko block_duration_minutes should be quoted right?
block_duration_minutes = lookup(spot_options.value, "block_duration_minutes", null)
There was a problem hiding this comment.
yes, this looks like a bug
baibailiha
added a commit
to baibailiha/terraform-aws-eks
that referenced
this pull request
Sep 13, 2022
### [18.3.1](terraform-aws-modules/terraform-aws-eks@v18.3.0...v18.3.1) (2022-02-04) ### Bug Fixes * The `block_duration_minutes` attribute under launch template `spot_options` is not a required ([#1847](terraform-aws-modules/terraform-aws-eks#1847)) ([85dd887](terraform-aws-modules/terraform-aws-eks@85dd887))
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
block_duration_minutesunder launch templatespot_optionsis not a required attributecompelteexample, external EKS managed node group module which was missing the security group IDs and failing to join the clusterMotivation and Context
Breaking Changes
How Has This Been Tested?
examples/*projects