fix: Set image_id to come from the launch template instead of data source for self-managed node groups
#2239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…utput of the launch template
bushong1
changed the title
bushong1
changed the title
1 task
bryantbiggs
changed the title
image_id to come from the launch template instead of data source for self-managed node groups
bryantbiggs
approved these changes
Sep 26, 2022
antonbabenko
pushed a commit
that referenced
this pull request
Sep 26, 2022
### [18.29.1](v18.29.0...v18.29.1) (2022-09-26) ### Bug Fixes * Set `image_id` to come from the launch template instead of data source for self-managed node groups ([#2239](#2239)) ([c5944e5](c5944e5))
|
This PR is included in version 18.29.1 🎉 |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes issue #2235 ; configure the output of image id to be the real output of the launch_template
Motivation and Context
#2235
Breaking Changes
If a user provided a custom ami_id and relied on the broken information this submodule was returning, they could see a change in behavior as the output corrects itself.
How Has This Been Tested?
examples/*to demonstrate and validate my change(s)examples/*projectsexamples/self_managed_node_groupterraform output -json | jq .self_managed_node_groups.value.bottlerocket.image_idami-0f2b7c6874eb8414f(The default AMI, despite being overridden in the config)ami-04958b57e72e69fb0(The actual bottlerocket ami id)pre-commit run -aon my pull request