feat: Ignore changes to labels and annotations on on aws-auth ConfigMap
#2380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tations to increase compatability with externally managed aws-auth ConfigMaps.
bryantbiggs
changed the title
aws-auth ConfigMap
antonbabenko
pushed a commit
that referenced
this pull request
Jan 5, 2023
## [19.5.0](v19.4.3...v19.5.0) (2023-01-05) ### Features * Ignore changes to labels and annotations on on `aws-auth` ConfigMap ([#2380](#2380)) ([5015b42](5015b42))
|
This PR is included in version 19.5.0 🎉 |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As per #2379, we manage the contents of the
aws-authConfigMap with GitOps and ArgoCD.The only issue we have is that ArgoCD automatically adds a label to every resource it updates and because
lifecycle_ignoreis only set ondatawe always haveterraformwanting to remove themetadata.labeladded by ArgoCD (even though we havemanage_aws_auth_configmap=falseset, which semantically implies that this won't happen).Motivation and Context
Fixes: #2379
Breaking Changes
This causes has no breaking changes.
How Has This Been Tested?
pre-commit run -aon my pull request