fix: AMI lookup should only happen when launch template is created #2386
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Given that
data.aws_ami.eks_default
is only used in theaws_launch_template.this
resource, which has a conditionalvar.create_launch_template
, the data block has been updated to have the same conditional. This means thatvar.cluster_version
is no longer needed to be passed whenvar.create_launch_template
is set to false (ie. when the available EKS AMIs make no difference to the resources actually being created).Motivation and Context
Fixes #2385
Breaking Changes
No breaking changes
How Has This Been Tested?
examples/*
to demonstrate and validate my change(s)examples/*
projectspre-commit run -a
on my pull requestTested with change made against latest on master branch, and the variables shown in related issue.
Prior to change, omission of
cluster_version
results in:After change, omission of
cluster_version
is valid