Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add Name tag for EKS cloudwatch log group #2500

Conversation

visokoo
Copy link
Contributor

@visokoo visokoo commented Mar 1, 2023

Description

Add additional Name tag to the cloudwatch log group resource.

Motivation and Context

In addition to the name of the log group itself, we wanted to add the log group name tag as well for our own cost reporting.

How Has This Been Tested?

  • I have executed pre-commit run -a on my pull request

Ran this change locally against my existing EKS cluster. Here's an example of the plan below:

  # module.eks.aws_cloudwatch_log_group.this[0] will be updated in-place
  ~ resource "aws_cloudwatch_log_group" "this" {
        id                = "/aws/eks/awesome_cluster/cluster"
        name              = "/aws/eks/awesome_cluster/cluster"
      ~ tags              = {
          + "Name" = "/aws/eks/awesome_cluster/cluster"
        }
      ~ tags_all          = {
          + "Name"             = "/aws/eks/awesome_cluster/cluster"
            # (5 unchanged elements hidden)
        }
        # (3 unchanged attributes hidden)
    }

main.tf Show resolved Hide resolved
@bryantbiggs bryantbiggs merged commit e64a490 into terraform-aws-modules:master Mar 23, 2023
antonbabenko pushed a commit that referenced this pull request Mar 23, 2023
### [19.10.2](v19.10.1...v19.10.2) (2023-03-23)

### Bug Fixes

* Add Name tag for EKS cloudwatch log group ([#2500](#2500)) ([e64a490](e64a490))
@antonbabenko
Copy link
Member

This PR is included in version 19.10.2 🎉

@visokoo visokoo deleted the vta-add-name-tag-to-cloudwatch-log-group branch March 28, 2023 20:12
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants