From e245fd615b33f3bf39581484bd972791db586bc6 Mon Sep 17 00:00:00 2001 From: Max Williams Date: Thu, 2 May 2019 16:14:15 +0200 Subject: [PATCH] Disabling ASG process AZRebalance by default --- CHANGELOG.md | 1 + README.md | 4 ++-- local.tf | 4 ++-- 3 files changed, 5 insertions(+), 4 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 6459488cce..85e751fb7f 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -16,6 +16,7 @@ project adheres to [Semantic Versioning](http://semver.org/). ### Changed + - Set default suspended processes for ASG to `AZRebalance` (by @max-rocket-internet) - Add .prettierignore file (by @rothandrew) - Switch to https for the pre-commit repos (by @rothandrew) - Add instructions on how to enable the docker bridge network (by @rothandrew) diff --git a/README.md b/README.md index e882fe9a06..777d8c05cb 100644 --- a/README.md +++ b/README.md @@ -171,8 +171,8 @@ MIT Licensed. See [LICENSE](https://github.com/terraform-aws-modules/terraform-a | config\_map\_aws\_auth | A kubernetes configuration to authenticate to this EKS cluster. | | kubeconfig | kubectl config file contents for this EKS cluster. | | kubeconfig\_filename | The filename of the generated kubectl config. | -| worker\_iam\_instance\_profile\_arns | default IAM instance profile ARNs for EKS worker group | -| worker\_iam\_instance\_profile\_names | default IAM instance profile names for EKS worker group | +| worker\_iam\_instance\_profile\_arns | default IAM instance profile ARN for EKS worker groups | +| worker\_iam\_instance\_profile\_names | default IAM instance profile name for EKS worker groups | | worker\_iam\_role\_arn | default IAM role ARN for EKS worker groups | | worker\_iam\_role\_name | default IAM role name for EKS worker groups | | worker\_security\_group\_id | Security group ID attached to the EKS workers. | diff --git a/local.tf b/local.tf index 8cb8923d15..ce09a293f1 100644 --- a/local.tf +++ b/local.tf @@ -35,7 +35,7 @@ locals { additional_security_group_ids = "" # A comma delimited list of additional security group ids to include in worker launch config protect_from_scale_in = false # Prevent AWS from scaling in, so that cluster-autoscaler is solely responsible. iam_role_id = "${local.default_iam_role_id}" # Use the specified IAM role if set. - suspended_processes = "" # A comma delimited string of processes to to suspend. i.e. AZRebalance,HealthCheck,ReplaceUnhealthy + suspended_processes = "AZRebalance" # A comma delimited string of processes to to suspend. i.e. AZRebalance,HealthCheck,ReplaceUnhealthy target_group_arns = "" # A comma delimited list of ALB target group ARNs to be associated to the ASG enabled_metrics = "" # A comma delimited list of metrics to be collected i.e. GroupMinSize,GroupMaxSize,GroupDesiredCapacity placement_group = "" # The name of the placement group into which to launch the instances, if any. @@ -80,7 +80,7 @@ locals { additional_security_group_ids = "" # A comma delimited list of additional security group ids to include in worker launch config protect_from_scale_in = false # Prevent AWS from scaling in, so that cluster-autoscaler is solely responsible. iam_role_id = "${local.default_iam_role_id}" # Use the specified IAM role if set. - suspended_processes = "" # A comma delimited string of processes to to suspend. i.e. AZRebalance,HealthCheck,ReplaceUnhealthy + suspended_processes = "AZRebalance" # A comma delimited string of processes to to suspend. i.e. AZRebalance,HealthCheck,ReplaceUnhealthy target_group_arns = "" # A comma delimited list of ALB target group ARNs to be associated to the ASG enabled_metrics = "" # A comma delimited list of metrics to be collected i.e. GroupMinSize,GroupMaxSize,GroupDesiredCapacity placement_group = "" # The name of the placement group into which to launch the instances, if any.