Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add ci-cd workflow for pre-commit checks #112

Merged

Conversation

bryantbiggs
Copy link
Member

Description

  • add ci-cd workflow for pre-commit checks

Motivation and Context

  • provide static checks for pull requests

Breaking Changes

  • no

How Has This Been Tested?

  • copy of what is implemented in SQS module repository

@antonbabenko antonbabenko merged commit 8449cb4 into terraform-aws-modules:master Feb 21, 2021
@antonbabenko
Copy link
Member

Couple of issues and ideas - https://github.com/terraform-aws-modules/terraform-aws-lambda/runs/1947301594?check_suite_focus=true :

  1. I think we need to verify and panic only if anything fails when using max version
  2. I think we need to disable terraform_fmt, terraform_docs, terraform_tflint checks when using min version because Terraform updates fmt and terraform-docs changing behavior from time to time.

@bryantbiggs bryantbiggs deleted the chore/static-checks branch February 21, 2021 20:56
@github-actions
Copy link

github-actions bot commented Nov 9, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants