Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: package.py not found with -chdir option #136

Conversation

alexedwardjones
Copy link
Contributor

Description

Removed the working_dir option from package.tf.

Motivation and Context

Fixes an issue where using the -chdir option breaks because it can't find the package.py file.

#135

Breaking Changes

No

How Has This Been Tested?

Tested by running both terraform -chdir=tf apply and cd tf && terraform apply, both passed without throwing an error.

@alexedwardjones alexedwardjones force-pushed the fix/package-not-found-with-chdir branch from a42c678 to c17de38 Compare March 29, 2021 16:57
@alexedwardjones alexedwardjones changed the title Fixed package.py not found with -chdir option fix: package.py not found with -chdir option Mar 29, 2021
@alexedwardjones
Copy link
Contributor Author

Hey @antonbabenko, the above PR and related issue have been open for a while. Any chance you can take a look?

@antonbabenko antonbabenko merged commit f8f1fb3 into terraform-aws-modules:master Apr 13, 2021
@antonbabenko
Copy link
Member

Thanks, @alexedwardjones !

v1.46.0 has been just released.

@alexedwardjones alexedwardjones deleted the fix/package-not-found-with-chdir branch April 13, 2021 15:36
@github-actions
Copy link

github-actions bot commented Nov 9, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants