feat: Add topics parameter support for lambda event source #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antonbabenko
requested changes
Jul 7, 2021
There was a problem hiding this comment.
Please update versions.tf in the root module to use version 3.43.0 at least. See CHANGELOG.
Add support for other arguments of aws_lambda_event_source_mapping introduced in this release.
Update code of example in examples/event-source-mapping to confirm that it works as expected.
antonbabenko
changed the title
|
Thanks! v2.9.0 has been just released. |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add topics parameter for lambda event source
Motivation and Context
Add support to set topics for lambda event source. This is optional parameter for MSK according to https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/lambda_event_source_mapping
Breaking Changes
No
How Has This Been Tested?
Tested in my project.
topicsparameter can be attached for MSK event source mapping.