-
-
Notifications
You must be signed in to change notification settings - Fork 686
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Take patterns into account when computing hash #169
fix: Take patterns into account when computing hash #169
Conversation
9713664
to
b851a7b
Compare
b851a7b
to
f5771c1
Compare
Marking as draft as not everything works as expected (e.g. folders are lost in the target zip). |
3cfac03
to
98eea82
Compare
Issue resolved, |
98eea82
to
b447a7c
Compare
b447a7c
to
9f5d7fb
Compare
0b9e8af
to
58da4af
Compare
Have you finished this PR? I try to run it locally now and I don't see it working (same behavior as in |
6029948
to
4afb710
Compare
4afb710
to
3ed5d7e
Compare
The only thing that changes with this PR is the computed hash when files are excluded, package content stays the same. Don't you see differences in the plan with |
Right, I can see the difference in your output but not when I ran it a couple of hours ago. Let me try it again. |
Now I can see the difference. Thank you very much for this fix! v2.14.0 has been just released. |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Description
This PR takes patterns into account when computing hash.
This should resolve #53.
Motivation and Context
Without this change, files that are excluded from Zip packages with
!
prefixed patterns are still considered during hash computing, which triggers diff when plans are run on workspaces from different users.Example plan of the
examples/build-package
configuration frommaster
branch:Example plan of the
examples/build-package
configuration from mytake_patterns_into_account_for_hash
branch:Breaking Changes
This should not be a breaking change.
How Has This Been Tested?
examples/*
projectsTested this change with
examples/build-package
.I have also tested this change with my own terraform configurations for now.