Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove random provider because it is not used #172

Merged
merged 1 commit into from
Jul 8, 2021
Merged

fix: Remove random provider because it is not used #172

merged 1 commit into from
Jul 8, 2021

Conversation

llamahunter
Copy link
Contributor

Description

Remove unnecessary provider requirement

Motivation and Context

Introduces unneeded provider requirement on downstream users of this module.
Fix #167

Breaking Changes

Should not break anything, as random provider was unreferenced in main module.

How Has This Been Tested?

  • I have tested and validated these changes using one or more of the provided examples/* projects
    Did a successful terraform plan in examples/simple, and encountered no problems.
    Code inspection of other examples showed that they all declare random as a required provider if they use it.

@llamahunter llamahunter changed the title Random provider only needed by examples, not main module. fix: Random provider only needed by examples, not main module. Jul 8, 2021
@antonbabenko antonbabenko changed the title fix: Random provider only needed by examples, not main module. fix: Remove random provider because it is not used Jul 8, 2021
@antonbabenko antonbabenko merged commit a86a326 into terraform-aws-modules:master Jul 8, 2021
@antonbabenko
Copy link
Member

Thanks, @llamahunter !

v2.7.0 has been just released.

@llamahunter llamahunter deleted the remove-random-provider branch July 8, 2021 19:11
@github-actions
Copy link

github-actions bot commented Nov 9, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

random provider listed in versions.tf, but unused
2 participants