Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added support for Cross-Account ECR for docker-build module #227

Merged
merged 2 commits into from
Nov 5, 2021

Conversation

panessa
Copy link
Contributor

@panessa panessa commented Nov 5, 2021

Description

Support for Cross-Account ECR for docker-build module

Motivation and Context

AWS Lambda now supports cross-account container image pulling from Amazon Elastic Container Registry https://aws.amazon.com/about-aws/whats-new/2021/11/aws-lambda-support-cross-account-image-amazon-elastic-container-registry/

Breaking Changes

None

How Has This Been Tested?

  • I have tested and validated these changes using this example
module "docker_image" {
  source = "../../modules/docker-build"

  create_ecr_repo = false
  ecr_address     = "XXXXXXXX.dkr.ecr.eu-central-1.amazonaws.com"
  ecr_repo        = random_pet.this.id
  image_tag       = "1.0"
  source_path     = "context"
  build_args = {
    FOO = "bar"
  }
}

@antonbabenko antonbabenko changed the title Support for Cross-Account ECR for docker-build module feat: Added support for Cross-Account ECR for docker-build module Nov 5, 2021
@antonbabenko antonbabenko merged commit 7b17b6a into terraform-aws-modules:master Nov 5, 2021
@antonbabenko
Copy link
Member

Thanks, @panessa !

v2.24.0 has been just released.

@github-actions
Copy link

github-actions bot commented Nov 8, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants