Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added support for ephemeral storage (requires AWS provider version 4.8.0) #291

Conversation

liortct
Copy link
Contributor

@liortct liortct commented Mar 26, 2022

Description

Add support for configuring ephemeral storage size (/tmp file system) for lambda.

The changes include:

  • Upgrade AWS provider version to 4.8.0, which introduces support for the ephemeral storage size configuration feature.
  • Add a variable called ephemeral_storage_size and use this value in the main.tf.
  • Replace deprecated resource aws_s3_bucket_object to aws_s3_object.
  • Add an example for using the ephemeral_storage_size configuration.

Motivation and Context

The ephemeral storage configuration is a new feature in AWS lambda. I would like to be able to use this feature via Terraform.

Fixes #290

Breaking Changes

How Has This Been Tested?

I have added a new exame for this feature at example/ephemeral-storage that uses the new feature.
I have tested the new change via the terraform validate command.

@liortct liortct changed the title Feature/support ephemeral storage feat: support ephemeral storage Mar 26, 2022
@liortct liortct changed the title feat: support ephemeral storage feat: Support ephemeral storage Mar 26, 2022
Copy link
Member

@antonbabenko antonbabenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good and quick one! Please remove the example folder you added but add just one argument (ephemeral_storage_size = 10240) to examples/complete/main.tf in module lambda_function.

@antonbabenko antonbabenko changed the title feat: Support ephemeral storage feat: Added support for ephemeral storage Mar 26, 2022
@liortct
Copy link
Contributor Author

liortct commented Mar 26, 2022

@antonbabenko

Good and quick one! Please remove the example folder you added but add just one argument (ephemeral_storage_size = 10240) to examples/complete/main.tf in module lambda_function.

Done

@antonbabenko antonbabenko changed the title feat: Added support for ephemeral storage feat: Added support for ephemeral storage (requires AWS provider version 4.8.0) Mar 26, 2022
@antonbabenko
Copy link
Member

Merging like this. The feature is working as expected but currently examples/complete is failing due to the S3 bucket module is not being compatible with AWS provider v4 (terraform-aws-modules/terraform-aws-s3-bucket#139).

@antonbabenko antonbabenko merged commit f191bae into terraform-aws-modules:master Mar 26, 2022
antonbabenko pushed a commit that referenced this pull request Mar 26, 2022
## [2.37.0](v2.36.0...v2.37.0) (2022-03-26)

### Features

* Added support for ephemeral storage (requires AWS provider version 4.8.0) ([#291](#291)) ([f191bae](f191bae))
@antonbabenko
Copy link
Member

This PR is included in version 2.37.0 🎉

@jaikanthjay46
Copy link

jaikanthjay46 commented Mar 28, 2022

@antonbabenko People's scripts are going to break even if they have pinned this to v2 . Not all modules have been updated to support provider v4.

Since its a breaking change, it could have been timed better.

@antonbabenko
Copy link
Member

@jaikanthjay46 Good point! I missed this yesterday. I will make a major release instead.

antonbabenko pushed a commit that referenced this pull request Mar 28, 2022
## [2.37.0](v2.36.0...v2.37.0) (2022-03-28)

### Features

* Added support for ephemeral storage (requires AWS provider version 4.8.0) ([#291](#291)) ([f191bae](f191bae))
* Updated AWS provider to version 4.8 ([#294](#294)) ([79d3fdd](79d3fdd))
antonbabenko added a commit that referenced this pull request Mar 28, 2022
This is the correction after #291

BREAKING CHANGES:
- Yes
antonbabenko pushed a commit that referenced this pull request Mar 28, 2022
## [3.0.0](v2.36.0...v3.0.0) (2022-03-28)

### ⚠ BREAKING CHANGES

* Updated AWS provider to version 4.8 (#296)

### Features

* Added support for ephemeral storage (requires AWS provider version 4.8.0) ([#291](#291)) ([f191bae](f191bae))
* Updated AWS provider to version 4.8 ([#296](#296)) ([d4b55a8](d4b55a8)), closes [#291](#291)
@antonbabenko
Copy link
Member

This PR is included in version 3.0.0 🎉

@jaikanthjay46
Copy link

Thanks @antonbabenko, appreciate your rapid response 🥳 . You have single handedly stopped a StackOverflow exodus from happening.

@github-actions
Copy link

github-actions bot commented Nov 8, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ephemeral_storage attribute to Lambda module
3 participants