-
-
Notifications
You must be signed in to change notification settings - Fork 686
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Added support for ephemeral storage (requires AWS provider version 4.8.0) #291
feat: Added support for ephemeral storage (requires AWS provider version 4.8.0) #291
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good and quick one! Please remove the example folder you added but add just one argument (ephemeral_storage_size = 10240
) to examples/complete/main.tf
in module lambda_function
.
Done |
Merging like this. The feature is working as expected but currently |
## [2.37.0](v2.36.0...v2.37.0) (2022-03-26) ### Features * Added support for ephemeral storage (requires AWS provider version 4.8.0) ([#291](#291)) ([f191bae](f191bae))
This PR is included in version 2.37.0 🎉 |
@antonbabenko People's scripts are going to break even if they have pinned this to v2 . Not all modules have been updated to support provider v4. Since its a breaking change, it could have been timed better. |
@jaikanthjay46 Good point! I missed this yesterday. I will make a major release instead. |
This is the correction after #291 BREAKING CHANGES: - Yes
## [3.0.0](v2.36.0...v3.0.0) (2022-03-28) ### ⚠ BREAKING CHANGES * Updated AWS provider to version 4.8 (#296) ### Features * Added support for ephemeral storage (requires AWS provider version 4.8.0) ([#291](#291)) ([f191bae](f191bae)) * Updated AWS provider to version 4.8 ([#296](#296)) ([d4b55a8](d4b55a8)), closes [#291](#291)
This PR is included in version 3.0.0 🎉 |
Thanks @antonbabenko, appreciate your rapid response 🥳 . You have single handedly stopped a StackOverflow exodus from happening. |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Description
Add support for configuring ephemeral storage size (/tmp file system) for lambda.
The changes include:
ephemeral_storage_size
and use this value in the main.tf.ephemeral_storage_size
configuration.Motivation and Context
The ephemeral storage configuration is a new feature in AWS lambda. I would like to be able to use this feature via Terraform.
Fixes #290
Breaking Changes
This upgrade is required as the
ephemeral_storage
configuration is added in version 4.8.0 of the AWS provider plugin - [Feature] Lambda Support for Ephemeral Storage upto 10GB hashicorp/terraform-provider-aws#23873.aws_s3_bucket_object
toaws_s3_object
becauseaws_s3_bucket_object
is deprecated - https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/s3_bucket_object.How Has This Been Tested?
I have added a new exame for this feature at
example/ephemeral-storage
that uses the new feature.I have tested the new change via the
terraform validate
command.