Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Override docker entrypoint when it exists #316

Merged
merged 2 commits into from
Sep 17, 2022
Merged

fix: Override docker entrypoint when it exists #316

merged 2 commits into from
Sep 17, 2022

Conversation

micah5
Copy link
Contributor

@micah5 micah5 commented Jun 9, 2022

Fixes #313

Description

When a base image contains an entrypoint path, it'll cause an entrypoint requires the handler name to be the first argument error to be thrown as the current run commend doesn't override it.

Motivation and Context

See issue #313. I am not sure when it happened, but the official AWS lambda runtime images started including entrypoints (lambci images still do not).

Breaking Changes

Nope

How Has This Been Tested?

Tested and working on my personal project. Official tests still todo:

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@micah5 micah5 changed the title fix: override docker entrypoint when it exists fix: Override docker entrypoint when it exists Jun 15, 2022
@github-actions
Copy link

This PR has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this PR will be closed in 10 days

@github-actions github-actions bot added the stale label Jul 16, 2022
@github-actions
Copy link

This PR was automatically closed because of stale in 10 days

@github-actions github-actions bot closed this Jul 26, 2022
@antonbabenko antonbabenko mentioned this pull request Sep 1, 2022
Closed
1 task
@deybhayden
Copy link

Could we reopen this one and merge? I tested the change locally and it fixed building packages with the public.ecr.aws/sam/build-pythonX images.

@antonbabenko antonbabenko reopened this Sep 17, 2022
@antonbabenko antonbabenko merged commit 3bb7623 into terraform-aws-modules:master Sep 17, 2022
@antonbabenko
Copy link
Member

Hi Ben! Thank you for checking out this issue!

Please take this fresh release and confirm that it works for you as expected.

antonbabenko pushed a commit that referenced this pull request Sep 17, 2022
@semantic-release-bot
chore(release): version 4.0.2 [skip ci]
8f99aaa 
### [4.0.2](v4.0.1...v4.0.2) (2022-09-17)

### Bug Fixes

* Override docker entrypoint when it exists ([#316](#316)) ([3bb7623](3bb7623))
@antonbabenko
Copy link
Member

This PR is included in version 4.0.2 🎉

@deybhayden
Copy link

Great, thanks so much!

@github-actions
Copy link

github-actions bot commented Nov 8, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Layer build error for python3.9
3 participants
@micah5 @deybhayden @antonbabenko