fix: Qualifiers in event invoke config #368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
create_current_version_async_event_config and create_unqualified_alias_async_event_config were not working due to zipmap returning a map with qualifier as key and null as value if variables were set to false
sindrig
changed the title
antonbabenko
approved these changes
Oct 27, 2022
antonbabenko
pushed a commit
that referenced
this pull request
Oct 27, 2022
### [4.2.1](v4.2.0...v4.2.1) (2022-10-27) ### Bug Fixes * Qualifiers in event invoke config ([#368](#368)) ([93e1dc3](93e1dc3))
|
This PR is included in version 4.2.1 🎉 |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
create_current_version_async_event_config and create_unqualified_alias_async_event_config were not working due to zipmap returning a map with qualifier as key and null as value if variables were set to false
Motivation and Context
there's currently no way to opt out of either current_version or unqualified_version for async event config
How Has This Been Tested?
examples/*to demonstrate and validate my change(s)examples/*projectspre-commit run -aon my pull requestI deployed the
examples/aliasexample and modified the variables before my change, resulting in no change in terraform state. Then I applied my change and ran apply, and terraform wanted to remove the resources, as it should.