Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add dynamic blocks for consumer group id config #399

Merged
merged 4 commits into from
Mar 10, 2023
Merged

feat: Add dynamic blocks for consumer group id config #399

merged 4 commits into from
Mar 10, 2023

Conversation

wilkejo
Copy link
Contributor

@wilkejo wilkejo commented Jan 16, 2023

Description

Add two more dynamic blocks within the lambda trigger config to allow defining kafka consumer group ids

Motivation and Context

Fixes #397

Breaking Changes

This isn't a breaking change

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@wilkejo wilkejo changed the title add dynamic blocks for consumer group id config feat: add dynamic blocks for consumer group id config Jan 16, 2023
@wilkejo wilkejo changed the title feat: add dynamic blocks for consumer group id config feat: Add dynamic blocks for consumer group id config Jan 16, 2023
@wilkejo
Copy link
Contributor Author

wilkejo commented Jan 16, 2023

I tested the changes within my setup and extended the example.

@github-actions
Copy link

This PR has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this PR will be closed in 10 days

@github-actions github-actions bot added the stale label Feb 16, 2023
@Nunalves
Copy link

Shouldn't be stale. Should be merged. This feature is needed.

@github-actions github-actions bot removed the stale label Feb 18, 2023
@antonbabenko antonbabenko merged commit 7d7bb79 into terraform-aws-modules:master Mar 10, 2023
antonbabenko pushed a commit that referenced this pull request Mar 10, 2023
## [4.11.0](v4.10.1...v4.11.0) (2023-03-10)

### Features

* Add dynamic blocks for consumer group id config ([#399](#399)) ([7d7bb79](7d7bb79))
@antonbabenko
Copy link
Member

This PR is included in version 4.11.0 🎉

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ability to set consumer group names for Amazon Managed and Self Managed Kafka cluster
3 participants