Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update docker provider pin to 2.x in docker-build submodule #401

Merged

Conversation

mbeacom
Copy link
Contributor

@mbeacom mbeacom commented Jan 18, 2023

Description

The goal of this PR is to resolve docker provider deprecation issues resulting from the docker provider transition to 3.x. This major update to the provider removes interface compatibility between docker_image and docker_remote_image.

Resolves: #398

Motivation and Context

Ensure the module works out of the box, until the module can be updated to use the latest variant of the docker provider implementation.

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@mbeacom mbeacom changed the title Fix #398 - Update docker provider pin to 2.x feat: Update docker provider pin to 2.x Jan 18, 2023
@antonbabenko antonbabenko changed the title feat: Update docker provider pin to 2.x feat: Update docker provider pin to 2.x in docker-build submodule Jan 18, 2023
@antonbabenko antonbabenko merged commit fc2a39b into terraform-aws-modules:master Jan 18, 2023
@antonbabenko
Copy link
Member

Thanks, @mbeacom !

antonbabenko pushed a commit that referenced this pull request Jan 18, 2023
## [4.8.0](v4.7.2...v4.8.0) (2023-01-18)

### Features

* Update docker provider pin to 2.x in docker-build submodule ([#401](#401)) ([fc2a39b](fc2a39b))
@antonbabenko
Copy link
Member

This PR is included in version 4.8.0 🎉

@mbeacom
Copy link
Contributor Author

mbeacom commented Jan 18, 2023

Thanks for the quick merge!

@mbeacom mbeacom deleted the adjust-docker-provider-pin branch January 19, 2023 15:17
@mbeacom
Copy link
Contributor Author

mbeacom commented Jan 25, 2023

@antonbabenko Just wanted to give you a heads up... Something may have failed in the release job. It appears the registry hasn't received 4.8.0 yet.

@antonbabenko
Copy link
Member

Thanks for the heads up! I just hit the Registry magic button to resync this module.

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug with docker-build module on latest tag and commti.
2 participants