feat: add Windows authentication

[bryantbiggs]

Description

• Add Windows authentication per https://www.terraform.io/docs/providers/aws/r/db_instance.html\#domain which is now supported by all RDS engines

closes #193

[bryantbiggs]

@antonbabenko let me know if I can be of help any on this module - quite a few open PRs but no updates since July. I have a few other changes that I will submitting for RDS enhancements now available in the api - thank you!

[antonbabenko]

Thanks for this small PR!

Please rebase or merge the master branch in, add outputs for domain and domain_iam_role_name since they are attributes of aws_db_instance resource, and update mssql example to show how this feature is supposed to be used for real.

[bryantbiggs]

@antonbabenko - updated the example and validated. Note, it takes about 25 minutes for AWS Directory Service (SimpleAD) to come up and another 15 for RDS, just keep in mind if you plan on running it. We might want to split this out as a standalone example for the AD integration, and the current would stay as it is - just a thought. I had to switch the region to us-east-1 since Directory Service is not available in us-west-x (Ref: here)

[hpAB]

please can we have this feature merged, mssql rds isnt very useful without auth

[hpAB]

great additional to the module

[bryantbiggs]

@terraform-aws-modules/triage-supporters / @antonbabenko if anyone gets a chance to review

[DrFaust92]

Tested with and without params, LGTM 🚀

[antonbabenko]

Thanks all for the work and verification!

v2.17.0 has been just released.

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.