fix: Correct usage of password and allow restored snapshots to set password, username, etc.
#384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spritekin
reviewed
Feb 18, 2022
antonbabenko
pushed a commit
that referenced
this pull request
Feb 18, 2022
### [4.1.2](v4.1.1...v4.1.2) (2022-02-18) ### Bug Fixes * Correct usage of `password` and allow restored snapshots to set password, username, etc. ([#384](#384)) ([81db512](81db512))
|
This PR is included in version 4.1.2 🎉 |
|
After the merge, I immediately realized that it should have been |
|
How do we properly grab the master password now that the parameter has been removed? |
with Line 62 in 55da7d3 |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
password- there were some dangling references tomaster_passwordthat have mostly been resolved (the random password generator name is left as is to avoid any disruptions for users of 4.x)Motivation and Context
not requiredwhen a snapshot identifier is provided (i.e. - can be null), but they *can be provided. only the replica option states that these values cannot be providedBreaking Changes
How Has This Been Tested?
examples/*projects