Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixed example of cross-region replica where KMS key was missing #428

Conversation

magreenbaum
Copy link
Member

Description

If you create an encrypted read replica in a different AWS Region, then you must specify a KMS key identifier for the destination AWS Region.

Motivation and Context

Fixes error:

Error: Error creating DB Instance: InvalidParameterCombination: Cannot create a cross region unencrypted read replica from encrypted source.

Breaking Changes

No

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

Copy link
Member

@antonbabenko antonbabenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this correction!

@antonbabenko antonbabenko changed the title fix: Example cross region replica missing kms key fix: Fixed example of cross-region replica where KMS key was missing Aug 15, 2022
@antonbabenko antonbabenko merged commit 88418a7 into terraform-aws-modules:master Aug 15, 2022
antonbabenko pushed a commit that referenced this pull request Aug 15, 2022
### [5.0.3](v5.0.2...v5.0.3) (2022-08-15)

### Bug Fixes

* Fixed example of cross-region replica where KMS key was missing ([#428](#428)) ([88418a7](88418a7))
@antonbabenko
Copy link
Member

This PR is included in version 5.0.3 🎉

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants