Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added optional bucket policy for requiring TLS 1.2 #126

Merged
merged 3 commits into from
Jan 15, 2022

Conversation

aiell0
Copy link
Contributor

@aiell0 aiell0 commented Jan 14, 2022

Description

This adds an additional parameter that toggles whether to add a bucket policy for requiring TLS 1.2 in order to access the bucket.

Motivation and Context

I'm working in an organization that requires TLS v1.2 on all of their buckets. I was already using the module and thought this is a common enough need in secure organizations that we should generalize it. I created an issue requesting the feature here: #125.

Fixes #125

Breaking Changes

No

How Has This Been Tested?

  • I have tested and validated these changes using one or more of the provided examples/* projects
    I tested using the examples/complete project by adding the new parameter on to the buckets. I confirmed in my console that the policy was created.

@aiell0 aiell0 changed the title Boolean parameter for TLS v1.2 policy feat: boolean parameter for TLS v1.2 policy Jan 14, 2022
@aiell0 aiell0 changed the title feat: boolean parameter for TLS v1.2 policy feat: Boolean parameter for TLS v1.2 policy Jan 14, 2022
@antonbabenko antonbabenko changed the title feat: Boolean parameter for TLS v1.2 policy feat: Added optional bucket policy for requiring TLS 1.2 Jan 15, 2022
@antonbabenko antonbabenko merged commit c56c684 into terraform-aws-modules:master Jan 15, 2022
antonbabenko pushed a commit that referenced this pull request Jan 15, 2022
## [2.13.0](v2.12.0...v2.13.0) (2022-01-15)

### Features

* Added optional bucket policy for requiring TLS 1.2 ([#126](#126)) ([c56c684](c56c684))
@antonbabenko
Copy link
Member

This PR is included in version 2.13.0 🎉

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Boolean parameter for TLS v1.2 policy
2 participants