-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Upgraded AWS provider to 4.5, fixed object_lock_enabled #149
Conversation
## [3.1.0](v3.0.1...v3.1.0) (2022-04-15) ### Features * Upgraded AWS provider to 4.5, fixed object_lock_enabled ([#149](#149)) ([70d08fd](70d08fd))
This PR is included in version 3.1.0 🎉 |
Thanks @antonbabenko |
All environment was broken all day because we set the module to |
@ZeroDeth Sorry for making it hard for you. In fact, version 3 of this module was always supposed to be working with AWS provider version 4. I was able to make it work with the previous version of the provider (version 3.75) for most parts, too, but it led to an unnecessary race between module & provider. Once more, sorry for the confusion! |
@antonbabenko no worries. I am already using most of your modules 🙂 Thank you! |
`terraform-aws-modules/s3-bucket/aws` requires `aws = ">= 4.5"` since the change terraform-aws-modules/terraform-aws-s3-bucket#149
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
It was too optimistic (and not feasible) to make it work with AWS provider version 3.75 as the lowest requirement.
AWS provider
v3.75
- the latest supported version of this module isv3.0.1
Fixed #148