Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Upgraded AWS provider to 4.5, fixed object_lock_enabled #149

Merged
merged 1 commit into from
Apr 15, 2022

Conversation

antonbabenko
Copy link
Member

@antonbabenko antonbabenko commented Apr 15, 2022

It was too optimistic (and not feasible) to make it work with AWS provider version 3.75 as the lowest requirement.

AWS provider v3.75 - the latest supported version of this module is v3.0.1

Fixed #148

@antonbabenko antonbabenko merged commit 70d08fd into master Apr 15, 2022
@antonbabenko antonbabenko deleted the feat-bucket-object-lock branch April 15, 2022 14:35
antonbabenko pushed a commit that referenced this pull request Apr 15, 2022
## [3.1.0](v3.0.1...v3.1.0) (2022-04-15)

### Features

* Upgraded AWS provider to 4.5, fixed object_lock_enabled ([#149](#149)) ([70d08fd](70d08fd))
@antonbabenko
Copy link
Member Author

This PR is included in version 3.1.0 🎉

@dnyaneshwar-sonawane
Copy link

Thanks @antonbabenko

@ZeroDeth
Copy link

All environment was broken all day because we set the module to version = "~> 3.0"  😢
Lesson learned and that the S3 module is unstable most of the time.

@antonbabenko
Copy link
Member Author

@ZeroDeth Sorry for making it hard for you.

In fact, version 3 of this module was always supposed to be working with AWS provider version 4. I was able to make it work with the previous version of the provider (version 3.75) for most parts, too, but it led to an unnecessary race between module & provider.

Once more, sorry for the confusion!

@ZeroDeth
Copy link

ZeroDeth commented Apr 16, 2022

@antonbabenko no worries. I am already using most of your modules 🙂 Thank you!

vzenkovich pushed a commit to setronica-dev/terraform-aws-s3-bucket that referenced this pull request Apr 18, 2022
vzenkovich pushed a commit to setronica-dev/terraform-aws-s3-bucket that referenced this pull request Apr 18, 2022
velimir pushed a commit to GameAnalytics/terraform-aws-atlantis that referenced this pull request Apr 25, 2022
`terraform-aws-modules/s3-bucket/aws` requires `aws = ">= 4.5"` since
the change terraform-aws-modules/terraform-aws-s3-bucket#149
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants