Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aws s3 bucket public access block #18

Merged
merged 4 commits into from
Mar 6, 2020
Merged

Aws s3 bucket public access block #18

merged 4 commits into from
Mar 6, 2020

Conversation

serhatcetinkaya
Copy link
Contributor

Prior to this change, the module didn't have support for blocking public access check here and here.

All the blocking defaults to true and can be adjusted with variables. Hopefully this PR resolves issues #7 and #17 .

New version can be tested with following example:

module "s3_bucket" {
  source = "github.com/serhatcetinkaya/terraform-aws-s3-bucket?ref=aws_s3_bucket_public_access_block"

  bucket = "my-s3-bucket-test-blocking-public-access"
  acl    = "private"

  versioning = {
    enabled = true
  }

}

@antonbabenko antonbabenko merged commit 2f3c6d1 into terraform-aws-modules:master Mar 6, 2020
@antonbabenko
Copy link
Member

Thank you!

v1.6.0 has been just released.

I updated the code a bit and set defaults to false (as AWS&Terraform AWS provider does).

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants