feat: Allow override of the default tags override #261
Conversation
|
This PR has been automatically marked as stale because it has been open 30 days |
|
Let's try to keep it open for a bit more. |
|
This PR has been automatically marked as stale because it has been open 30 days |
|
bump once more |
modules/object/main.tf
Outdated
| @@ -36,4 +36,13 @@ resource "aws_s3_object" "this" { | |||
| lifecycle { | |||
| ignore_changes = [object_lock_retain_until_date] | |||
| } | |||
|
|
|||
| override_provider { | |||
There was a problem hiding this comment.
Please change it so that the override_provider block is used only if necessary (override_default_tags should be true).
Also, please keep lifecycle block as the last one.
antonbabenko
changed the title
## [4.1.0](v4.0.1...v4.1.0) (2024-01-26) ### Features * Allow override of the default tags override ([#261](#261)) ([f9e1740](f9e1740))
|
This PR is included in version 4.1.0 🎉 |
|
Hello @antonbabenko. Sorry for the delay and thank you for fixing and merging this! |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Description
Added support for ignoring default_tags set on provider level.
Motivation and Context
This change was required as it was not possible to deploy s3 bucket object if there are more than 10 tags set on provider level.
More info here.
Breaking Changes
This is not a breaking change but it does require bumping the provider version for 2 major versions, as option was only recently added to provider.
How Has This Been Tested?
examples/*to demonstrate and validate my change(s)examples/*projectspre-commit run -aon my pull request