Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add types for logging input variable #287

Open
aldenquimby opened this issue Sep 9, 2024 · 6 comments
Open

Add types for logging input variable #287

aldenquimby opened this issue Sep 9, 2024 · 6 comments

Comments

@aldenquimby
Copy link

Is your request related to a new offering from AWS?

No

Is your request related to a problem? Please describe.

When working with the logging variable, it would be nice to get type autocomplete and documentation in an IDE

For example, I tried this:

  logging = {
    target_bucket = module.s3_access_log_s3_bucket.s3_bucket_id
    target_object_key_format = {
      partitioned_prefix = {
        partition_date_source = "DeliveryTime"
      }
    }
  }

Only to run into the error The argument "target_prefix" is required, but no definition was found

Describe the solution you'd like.

instead of any, logging could have a type like map(object({ ... })) with the expected properties

Describe alternatives you've considered.

alternative would be to use aws_s3_bucket_logging directly, instead of this module

Additional context

  • it looks like all other variable objects have type input. is there a reason for this?
  • I'd be happy to open a PR for this if you confirm you'll accept one
Copy link

This issue has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this issue will be closed in 10 days

@github-actions github-actions bot added the stale label Oct 10, 2024
@aldenquimby
Copy link
Author

commenting to remove stale. if a contributor confirms this makes sense, I will open a PR

@github-actions github-actions bot removed the stale label Oct 11, 2024
Copy link

This issue has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this issue will be closed in 10 days

@github-actions github-actions bot added the stale label Nov 10, 2024
@aldenquimby
Copy link
Author

commenting to remove stale. if a contributor confirms this makes sense, I will open a PR

@github-actions github-actions bot removed the stale label Nov 11, 2024
Copy link

This issue has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this issue will be closed in 10 days

@github-actions github-actions bot added the stale label Dec 11, 2024
@aldenquimby
Copy link
Author

commenting to remove stale

@github-actions github-actions bot removed the stale label Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant