Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added attach_public_policy as conditional switch #34

Merged
merged 3 commits into from
Jun 12, 2020

Conversation

Promaethius
Copy link
Contributor

Description

Add a bool which controls the creation of resource "aws_s3_bucket_public_access_block"

Motivation and Context

We have an environment where S3 buckets are being created under a role without PutBucketPolicy.

Breaking Changes

No, by default the behavior will remain the same.

How Has This Been Tested?

Tested against a role without PutBucketPolicy.

Promaethius added 2 commits June 12, 2020 11:40
attach_public_policy
attach_public_policy
@Promaethius Promaethius changed the title Public Policy switch feat: Public Policy switch Jun 12, 2020
@antonbabenko antonbabenko changed the title feat: Public Policy switch feat: Added attach_public_policy as conditional switch Jun 12, 2020
@antonbabenko antonbabenko merged commit 916cb34 into terraform-aws-modules:master Jun 12, 2020
@antonbabenko
Copy link
Member

Thanks, @Promaethius !

v1.8.0 has been just released.

@Promaethius
Copy link
Contributor Author

That's a heck of a turnaround time! Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants