Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add bucket acl policy grants #44

Conversation

bryantbiggs
Copy link
Member

@bryantbiggs bryantbiggs commented Sep 14, 2020

Description

  • add ability to provide grant statement blocks
  • update pre-commit hooks to latest
  • update complete example to add cloudfront log bucket example using var.grant added here

closes #20

Motivation and Context

  • grant is useful in scenarios when setting up access for CloudFront to write logs to your bucket or with cross account access to write files to a bucket you own

Breaking Changes

  • no

How Has This Been Tested?

  • via updating and deploying complete example

source = "../../"

bucket = "cloudfront-logs-${random_pet.this.id}"
acl = null # conflicts with default of `acl = "private"` so set to null to use grants
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this does work; since acl and grant conflict (and you will get a message stating as much unless you add this). the alternative would be to change the default for acl to be "" or null, but that would be a breaking change so this seemed like a better compromise. maybe there is a place to better document this? open to suggestions

@bryantbiggs
Copy link
Member Author

@antonbabenko let me know if you have any thoughts on the proposed changes

@antonbabenko antonbabenko merged commit e74d150 into terraform-aws-modules:master Oct 6, 2020
@antonbabenko
Copy link
Member

Thanks, @bryantbiggs !

v1.13.0 has been just released.

@bryantbiggs bryantbiggs deleted the feature/add-bucket-acl-policy-grants branch October 6, 2020 12:06
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request - S3 ACL Policy Grant
2 participants