Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add skip_destroy to vpc flow log cloudwatch log group #1009

Conversation

magreenbaum
Copy link
Member

@magreenbaum magreenbaum commented Nov 18, 2023

Description

Add skip_destroy to aws_cloudwatch_log_group.

Motivation and Context

Closes: #1007

Breaking Changes

No.

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

Copy link
Member

@bryantbiggs bryantbiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First added in v4.40 so safe to add - thank you!

@bryantbiggs bryantbiggs merged commit abe2c0f into terraform-aws-modules:master Nov 18, 2023
20 checks passed
antonbabenko pushed a commit that referenced this pull request Nov 18, 2023
## [5.2.0](v5.1.2...v5.2.0) (2023-11-18)

### Features

* Add `skip_destroy` to vpc flow log cloudwatch log group ([#1009](#1009)) ([abe2c0f](abe2c0f))
@antonbabenko
Copy link
Member

This PR is included in version 5.2.0 🎉

@magreenbaum magreenbaum deleted the feat/vpc_flow_log_group_skip_destroy branch November 18, 2023 16:37
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add skip_destroy for aws_cloudwatch_log_group
3 participants