feat: Add Cross Account Flow Support #1014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@antonbabenko anything else we need to do for this? |
bryantbiggs
reviewed
Dec 11, 2023
| log_destination = local.flow_log_destination_arn | ||
| log_format = var.flow_log_log_format | ||
| iam_role_arn = local.flow_log_iam_role_arn | ||
| deliver_cross_account_role = var.flow_log_deliver_cross_account_role |
There was a problem hiding this comment.
Added in v4.58.0 - should be safe to add support
bryantbiggs
approved these changes
Dec 11, 2023
antonbabenko
pushed a commit
that referenced
this pull request
Dec 11, 2023
## [5.4.0](v5.3.0...v5.4.0) (2023-12-11) ### Features * Add Cross Account Flow Support ([#1014](#1014)) ([6e25437](6e25437))
|
This PR is included in version 5.4.0 🎉 |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support for cross-account vpc flow
Motivation and Context
Need to be able to send vpc flow logs to another account used for centralized log archival where they will be ingested by a Kinesis Firehose
Breaking Changes
No, I don't expect any breaking changes.
How Has This Been Tested?