Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for dns_options on VPC endpoints #1023

Merged
merged 7 commits into from
Jan 9, 2024

Conversation

erezo9
Copy link
Contributor

@erezo9 erezo9 commented Dec 18, 2023

Description

add dns_options block to use it in cases of endpoints that support gateway and interface

Motivation and Context

Breaking Changes

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects

there is no user input change, if the array is not existend or private_dns_enabled is false it will not trigger a change

tested locally

  • I have executed pre-commit run -a on my pull request

@erezo9 erezo9 changed the title add dns_options dynamic block feat: Add dns_options dynamic block Dec 18, 2023
@erezo9
Copy link
Contributor Author

erezo9 commented Dec 21, 2023

@antonbabenko if you could please review this or tag relavent people to review
will be super helpful if this be in the next version

Copy link

@zach-nicoll-wcq zach-nicoll-wcq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would love to see this merged!! Currently blocking a private MWAA deployment because Terraform doesn't support this.

@erezo9
Copy link
Contributor Author

erezo9 commented Jan 9, 2024

@bryantbiggs
Can you please review this MR, i cant assign reviewers to view this code and it will really help in the provisioning

@bryantbiggs bryantbiggs changed the title feat: Add dns_options dynamic block feat: Add support for dns_options on VPC endpoints Jan 9, 2024
@bryantbiggs bryantbiggs merged commit 32f853f into terraform-aws-modules:master Jan 9, 2024
21 checks passed
antonbabenko pushed a commit that referenced this pull request Jan 9, 2024
## [5.5.0](v5.4.0...v5.5.0) (2024-01-09)

### Features

* Add support for `dns_options` on VPC endpoints ([#1023](#1023)) ([32f853f](32f853f))
@antonbabenko
Copy link
Member

This PR is included in version 5.5.0 🎉

@erezo9
Copy link
Contributor Author

erezo9 commented Jan 10, 2024

@bryantbiggs thanks for merging
why did you change the looping validation and the check on the private_dns_enabled?
i added it so it could prevent users from using this when its type gateway and when private_dns_enabled = true the value should not exist

@bryantbiggs
Copy link
Member

the value should not exist

Then users should not provide it. Sometimes we can provide the means to help users avoid misconfiguration, but in this scenario the logic would be overly complex

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot create S3 VPC Endpoint with private DNS enabled.
4 participants