Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Correct VPC endpoint private DNS resolver for_each key #1029

Merged

Conversation

bryantbiggs
Copy link
Member

Description

  • Correct VPC endpoint private DNS resolver for_each key

Motivation and Context

Breaking Changes

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@antonbabenko antonbabenko merged commit a837be1 into terraform-aws-modules:master Jan 13, 2024
19 checks passed
antonbabenko pushed a commit that referenced this pull request Jan 13, 2024
### [5.5.1](v5.5.0...v5.5.1) (2024-01-13)

### Bug Fixes

* Correct VPC endpoint private DNS resolver `for_each` key ([#1029](#1029)) ([a837be1](a837be1))
@antonbabenko
Copy link
Member

This PR is included in version 5.5.1 🎉

@bryantbiggs bryantbiggs deleted the fix/vpc-endpoint branch January 13, 2024 21:06
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

private_dns_only_for_inbound_resolver_endpoint value for s3 vpc endpoints is ignored.
2 participants