-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VPC endpoints are being replaced sporadically due to service_name
being unknown at plan time
#1054
Comments
We are also encountering this and it is forcing endpoint creation when we just want to update our Tags for the module. |
@zack-is-cool your issue is most likely related to this https://github.com/defenseunicorns/terraform-aws-vpc/blob/f21519a579225c4f7a6e0efc05cf2cf96f0a8b89/main.tf#L255 @jordanboston do you have an explicit |
It's odd that it's not replacing them each time the TF is applied though? This code is being deployed to long lived environments and just seems to randomly decide it doesn't know the vpc endpoints - this is without messing with the Assuming I can't get rid of this
|
This issue has been resolved in version 5.7.0 🎉 |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Description
vpc endpoints flapping sporadically due to hashicorp/terraform-provider-aws#25568.
Commented on problem here:
hashicorp/terraform-provider-aws#25568 (comment)
Versions
Module version [Required]:
v5.5.3
Terraform version:
Terraform v1.5.7
on darwin_arm64
Provider version(s):
aws 2.4.1
Reproduction Code [Required]
defenseunicorns/terraform-aws-vpc@main/main.tf#L130-L256 which feeds into this ->
terraform-aws-modules/terraform-aws-vpc@master/modules/vpc-endpoints/main.tf#L11-L21
Steps to reproduce the behavior:
Expected behavior
They should not be replaced if nothing is changing.
Actual behavior
The VPC endpoints are forced to be replace due to the use of the
aws_vpc_endpoint_service
data source, sometimes. This is due to them being known after apply.Terminal Output Screenshot(s)
basically this, for all VPC endpoints, sometimes.
Additional context
possible solution
Ideally this module should allow the use of feeding in a
service_name
and doing alookup()
on that so that we can build it outside when passing in the map ofendpoints
, but defaulting todata.aws_vpc_endpoint_service.this[each.key].service_name
if none provided.The text was updated successfully, but these errors were encountered: