Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow custom VPC Flow Log IAM Role name and IAM Policy name #1089

Merged

Conversation

carstensh
Copy link
Contributor

Description

Allow custom IAM Role and Policy names for the VPC flow log either by specifying the entire name, or by providing a prefix.

Motivation and Context

Some organizations require specific prefixes or naming schemes on IAM policies and roles. This allows support for that following the same pattern as in other terraform-aws-modules

Breaking Changes

Not a breaking change.

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

Copy link

github-actions bot commented Jul 5, 2024

This PR has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this PR will be closed in 10 days

@github-actions github-actions bot added the stale label Jul 5, 2024
@carstensh
Copy link
Contributor Author

bump

@bryantbiggs bryantbiggs merged commit f8cd168 into terraform-aws-modules:master Jul 5, 2024
18 checks passed
antonbabenko pushed a commit that referenced this pull request Jul 5, 2024
## [5.9.0](v5.8.1...v5.9.0) (2024-07-05)

### Features

* Allow custom VPC Flow Log IAM Role name and IAM Policy name ([#1089](#1089)) ([f8cd168](f8cd168))
@antonbabenko
Copy link
Member

This PR is included in version 5.9.0 🎉

Copy link

github-actions bot commented Aug 5, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants