Allow passing in EIPs for the NAT Gateways #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antonbabenko
reviewed
Dec 6, 2017
| @@ -152,16 +156,28 @@ resource "aws_elasticache_subnet_group" "elasticache" { | |||
| ############## | |||
| # NAT Gateway | |||
| ############## | |||
| # Workaround for interpolation not being able to "short-circuit" the evaluation of the conditional branch that doesn't end up being used | |||
variables.tf
Outdated
| @@ -65,6 +65,17 @@ variable "single_nat_gateway" { | |||
| default = false | |||
| } | |||
|
|
|||
| variable "reuse_nat_ips" { | |||
| description = "Should be true if you don't want EIPs to be created for your NAT Gateways and will instead pass them in via the external_nat_ips variable" | |||
There was a problem hiding this comment.
Change: external_nat_ips => external_nat_ip_ids
miguelaferreira
force-pushed
the
external-ip-nat-gateway
branch
4 times, most recently
from
126e813
to
556fb60
Compare
miguelaferreira
force-pushed
the
external-ip-nat-gateway
branch
from
556fb60
to
ce0c488
Compare
|
Thank you for taking the time to review my PR. I've pushed the changes you requested. Please let me know if there's anything else. |
|
Thanks! v1.9.0 is now released. |
|
Great! Thank you for the corrections to the documentation and the fast release of a new version. |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds enables passing in external EIPs to be assigned to the NAT Gateways (Fixes #37).
To that end, this PR:
I have not documented the feature because I would like some input from the maintainers of the module on where to document this. If the PR is accepted, I could add the documentation to the main README file, to the existing examples, or even make a new example.