-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Manage Default Route Table under Terraform #69
Manage Default Route Table under Terraform #69
Conversation
- With name - And Tags
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good stuff!
Few comments... You are making normal aws_route_table, but you probably wanted to use aws_default_route_table.
Do you want to have aws_default_route_table
together with aws_main_route_table_association
despite the warning?
You're right. I'll change the PR to tag |
eb11360
to
c474be5
Compare
@antonbabenko I've pushed the changes. |
This change is not as small as it may seem because it reassigns |
v1.20.0 has been released. |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
So that the default route table will be named and tagged accordingly instead of being unnamed and untagged.