feat: Add IPAM IPv4 support #716

drewmullen · 2021-12-02T21:12:49Z

Description

Closes Add support for AWS IPAM VPCs - IPv4 #715
Closes Update outputs.tf #829
Closes feat: Add support for IPAM #830

Motivation and Context

AWS launched VPC IPAM service

Breaking Changes

none

How Has This Been Tested?

I have tested and validated these changes using one or more of the provided examples/* projects

terraform init
terraform apply

I also attempted to implement terraform test but ran into a breaking bug

drewmullen · 2021-12-02T21:28:14Z

can you please help a guy out with the correct terraform-docs command to run? pre-commit is showing skipped in my terminal:
Terraform docs.......................................(no files to check)Skipped

bryantbiggs · 2021-12-02T21:32:15Z

@drewmullen pre-commit run -a

drewmullen · 2021-12-02T21:37:42Z

thank you, @bryantbiggs . not sure why it was skipping b4 but 🤷

fix is pushed.

main.tf

variables.tf

drewmullen · 2021-12-20T18:36:52Z

requesting to hold while this is investigated: #715 (comment)

drewmullen · 2022-01-20T14:08:23Z

hoping this data source will allow us to use this module and maintain subnet creation: hashicorp/terraform-provider-aws#22643

commenting for staleness

drewmullen · 2022-01-26T16:26:54Z

The last commit used precommit -no-verify because the example is currently broken and should not be used. I pushed it in case anyone else has recommendations.

Context: VPC module allows users to specify the subnets they want to create inside the VPC, this requires setting the cidr range for each subnet. Using AWS IPAM you may get your VPC CIDR derived from IPAM which means you wont know which subnet cidrs to use. The included examples/ipam-vpc/main.tf attempts to calculate the values by previewing the next cidr that will be used when a VPC is requested:

data "aws_vpc_ipam_preview_next_cidr" "previewed_cidr" {
  ipam_pool_id   = aws_vpc_ipam_pool.ipv4_example.id
  netmask_length = 24

  depends_on = [
    aws_vpc_ipam_pool_cidr.ipv4_example
  ]
}

locals {
  partition = cidrsubnets(data.aws_vpc_ipam_preview_next_cidr.previewed_cidr.cidr, 2, 2)
  private_subnets = cidrsubnets(local.partition[0], 2, 2)
  public_subnets = cidrsubnets(local.partition[1], 2, 2)
}

module "ipv4_ipam_calculate_subnets" {
  source            = "../.."
  name              = "ipv4-calculated-subnets-${local.name}"
  ipv4_ipam_pool_id = aws_vpc_ipam_pool.ipv4_example.id
  cidr              = data.aws_vpc_ipam_preview_next_cidr.previewed_cidr.cidr
  private_subnets   = local.private_subnets
  public_subnets    = local.public_subnets
  depends_on = [
    aws_vpc_ipam_pool_cidr.ipv4_example
  ]
}

ERRORs:

│ Error: Error in function call
│ 
│   on ../../main.tf line 424, in resource "aws_subnet" "private":
│  424:         element(var.azs, count.index),
│     ├────────────────
│     │ count.index is 0
│     │ var.azs is empty list of string

Youll find many similar errors when you run terraform apply. I believe the root cause may be use of count instead of for_each, but I'm honestly not sure.

Any input?

drewmullen · 2022-02-26T15:29:39Z

I had an epiphany! I have solved this issue. Ill clean up the PR and add some documentation to make usage more clear. Hopefully can push Monday!

drewmullen · 2022-02-26T16:37:01Z

Ready for a re-review. Appreciate the patience while I figure this one out!

Tested:

cd examples/ipam-vpc
terraform apply -auto-approve && terraform destroy -auto-approve

drewmullen · 2022-02-26T16:42:48Z

Any input on what is causing the failure in vpc-flow-logs example? Shouldnt be any effects due to my change (1 new argument / variable)

bryantbiggs · 2022-09-25T13:00:29Z

examples/complete-vpc/main.tf

 }

 locals {
-  name   = "complete-example"
+  name   = "ex-${replace(basename(path.cwd), "_", "-")}"


All of the provider/locals/tags updates were my fault - just aligning the examples to be consistent

bryantbiggs · 2022-09-25T13:01:33Z

examples/ipam-vpc/README.md

+
+```bash
+$ terraform destroy -target=module.vpc # destroy VPC that uses the IPAM pool CIDR first
+$ terraform destroy


not sure why, but deleting the aws_vpc_ipam_pool_cidr.this takes forever 🤷🏽‍♂️

It would be great to combine these two terraform destroy into one, as we have in all other modules, but I could not find a way to do this now. Let's leave it as it is now.

not sure why, but deleting the aws_vpc_ipam_pool_cidr.this takes forever 🤷🏽‍♂️

The service holds the allocation record for up to 30m after a vpc releases it. It's possible to ignore the allocation and delete faster but conflicts with terraforms paradigm

Oh, good to know!

bryantbiggs · 2022-09-25T13:03:06Z

apologies for the delay, I think when I first followed these PRs I was under the impression that they were breaking changes. @antonbabenko what do you think?

antonbabenko

Minor comments, but LGTM.

README.md

antonbabenko · 2022-09-25T14:45:27Z

examples/ipam-vpc/README.md

+
+```bash
+$ terraform destroy -target=module.vpc # destroy VPC that uses the IPAM pool CIDR first
+$ terraform destroy


It would be great to combine these two terraform destroy into one, as we have in all other modules, but I could not find a way to do this now. Let's leave it as it is now.

examples/ipam-vpc/versions.tf

examples/ipam-vpc/main.tf

Co-authored-by: drewmullen <mullen.drew@gmail.com>

## [3.15.0](v3.14.4...v3.15.0) (2022-09-25) ### Features * Add IPAM IPv4 support ([#716](#716)) ([6eddcad](6eddcad))

antonbabenko · 2022-09-25T17:13:54Z

This PR is included in version 3.15.0 🎉

antonbabenko · 2022-09-25T18:19:41Z

The PR has been finally merged - it's time for the party at AWS re:invent 2022 🎉🥳 Agree?

drewmullen · 2022-09-25T18:46:39Z

@antonbabenko 100%! I'll be there! We should do a informal tf community meet-up or something

antonbabenko · 2022-09-25T20:17:49Z

@drewmullen I agree we can make a more planned Terraform community meetup. I need to know what is the program for and by AWS Heroes, first. Stay in touch!

bryantbiggs · 2022-09-25T20:33:54Z

We'll need a 🍻 budget

github-actions · 2022-10-28T02:42:20Z

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

drewmullen force-pushed the ipam-ipv4 branch from 4439d92 to 668f92a Compare December 2, 2021 21:37

bryantbiggs reviewed Dec 2, 2021

View reviewed changes

main.tf Outdated Show resolved Hide resolved

variables.tf Outdated Show resolved Hide resolved

add ipam ipv4 support

3646569

drewmullen force-pushed the ipam-ipv4 branch from c92e5af to 3646569 Compare December 2, 2021 22:18

drewmullen mentioned this pull request Dec 8, 2021

feat: Add IPAM IPv6 support #718

Merged

1 task

drewmullen mentioned this pull request Dec 20, 2021

Add support for AWS IPAM VPCs - IPv4 #715

Closed

drewmullen changed the title ~~add ipam ipv4 support~~ [HOLD] add ipam ipv4 support Dec 20, 2021

github-actions bot added the stale label Jan 20, 2022

bryantbiggs added on hold and removed stale labels Jan 20, 2022

precommit no verify - broken ipam example

ee37b06

github-actions bot added the stale label Feb 26, 2022

rm ipam_netmask options, add docs

5e88357

drewmullen changed the title ~~[HOLD] add ipam ipv4 support~~ feat: Add IPAM IPv4 Support Feb 26, 2022

drewmullen requested a review from bryantbiggs February 26, 2022 16:36

revert cidr default back to 0./0

7036a6d

drewmullen force-pushed the ipam-ipv4 branch from ae3ca3f to 7036a6d Compare February 26, 2022 18:09

github-actions bot removed the stale label Feb 27, 2022

github-actions bot added the stale label Mar 30, 2022

github-actions bot closed this Apr 9, 2022

bryantbiggs reopened this Sep 9, 2022

bryantbiggs removed stale on hold labels Sep 9, 2022

bryantbiggs changed the title ~~feat: Add IPAM IPv4 Support~~ feat: Add IPAM IPv4 support Sep 9, 2022

chore: Update examples to align to current standards

1febc98

terraform-aws-modules deleted a comment from github-actions bot Sep 10, 2022

bryantbiggs added 2 commits September 25, 2022 08:05

Merge branch 'master' into ipam-ipv4

c6c76fd

chore: Updates from testing and validating IPAM example

f043552

bryantbiggs reviewed Sep 25, 2022

View reviewed changes

bryantbiggs approved these changes Sep 25, 2022

View reviewed changes

chore: Fix spelling mistake

1f377c6

antonbabenko reviewed Sep 25, 2022

View reviewed changes

antonbabenko added 2 commits September 25, 2022 16:47

Apply suggestions from code review

0fab714

Fixed docs

d3c8b6d

drewmullen commented Sep 25, 2022

View reviewed changes

examples/ipam-vpc/main.tf Outdated Show resolved Hide resolved

Update examples/ipam-vpc/main.tf

b259e7a

Co-authored-by: drewmullen <mullen.drew@gmail.com>

bryantbiggs merged commit 6eddcad into terraform-aws-modules:master Sep 25, 2022

antonbabenko pushed a commit that referenced this pull request Sep 25, 2022

chore(release): version 3.15.0 [skip ci]

6e356d2

## [3.15.0](v3.14.4...v3.15.0) (2022-09-25) ### Features * Add IPAM IPv4 support ([#716](#716)) ([6eddcad](6eddcad))

drewmullen deleted the ipam-ipv4 branch September 25, 2022 18:11

github-actions bot locked as resolved and limited conversation to collaborators Oct 28, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Add IPAM IPv4 support #716

feat: Add IPAM IPv4 support #716

drewmullen commented Dec 2, 2021 •

edited by bryantbiggs

Loading

drewmullen commented Dec 2, 2021

bryantbiggs commented Dec 2, 2021

drewmullen commented Dec 2, 2021

drewmullen commented Dec 20, 2021

drewmullen commented Jan 20, 2022

drewmullen commented Jan 26, 2022

drewmullen commented Feb 26, 2022

drewmullen commented Feb 26, 2022 •

edited

Loading

drewmullen commented Feb 26, 2022

bryantbiggs Sep 25, 2022

bryantbiggs Sep 25, 2022

antonbabenko Sep 25, 2022

drewmullen Sep 25, 2022

bryantbiggs Sep 25, 2022

bryantbiggs commented Sep 25, 2022

antonbabenko left a comment

antonbabenko Sep 25, 2022

antonbabenko commented Sep 25, 2022

antonbabenko commented Sep 25, 2022

drewmullen commented Sep 25, 2022

antonbabenko commented Sep 25, 2022 •

edited

Loading

bryantbiggs commented Sep 25, 2022

github-actions bot commented Oct 28, 2022

feat: Add IPAM IPv4 support #716

feat: Add IPAM IPv4 support #716

Conversation

drewmullen commented Dec 2, 2021 • edited by bryantbiggs Loading

Description

Motivation and Context

Breaking Changes

How Has This Been Tested?

drewmullen commented Dec 2, 2021

bryantbiggs commented Dec 2, 2021

drewmullen commented Dec 2, 2021

drewmullen commented Dec 20, 2021

drewmullen commented Jan 20, 2022

drewmullen commented Jan 26, 2022

drewmullen commented Feb 26, 2022

drewmullen commented Feb 26, 2022 • edited Loading

drewmullen commented Feb 26, 2022

bryantbiggs Sep 25, 2022

Choose a reason for hiding this comment

bryantbiggs Sep 25, 2022

Choose a reason for hiding this comment

antonbabenko Sep 25, 2022

Choose a reason for hiding this comment

drewmullen Sep 25, 2022

Choose a reason for hiding this comment

bryantbiggs Sep 25, 2022

Choose a reason for hiding this comment

bryantbiggs commented Sep 25, 2022

antonbabenko left a comment

Choose a reason for hiding this comment

antonbabenko Sep 25, 2022

Choose a reason for hiding this comment

antonbabenko commented Sep 25, 2022

antonbabenko commented Sep 25, 2022

drewmullen commented Sep 25, 2022

antonbabenko commented Sep 25, 2022 • edited Loading

bryantbiggs commented Sep 25, 2022

github-actions bot commented Oct 28, 2022

drewmullen commented Dec 2, 2021 •

edited by bryantbiggs

Loading

drewmullen commented Feb 26, 2022 •

edited

Loading

antonbabenko commented Sep 25, 2022 •

edited

Loading