Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only create one public route association for s3 endpoint #73

Merged

Conversation

steve-dave
Copy link
Contributor

@steve-dave steve-dave commented Feb 8, 2018

I noticed the module is currently creating one association per public subnet for the s3 endpoint, but there's only one public route table so it's only necessary to create one association.

@antonbabenko antonbabenko merged commit 6d7b091 into terraform-aws-modules:master Feb 9, 2018
@steve-dave steve-dave deleted the bugfix/pub-s3-ep-assoc branch February 13, 2018 20:15
@github-actions
Copy link

github-actions bot commented Nov 5, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants