Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added ability to specify CloudWatch Log group name for VPC Flow logs #847

Merged
merged 5 commits into from
Oct 21, 2022

Conversation

air3ijai
Copy link
Contributor

@air3ijai air3ijai commented Oct 15, 2022

Description

We can set a suffix to the CloudWatch Log group for VPC Flow log by defining a variable and if not defined, we will use an old approach and use VPC ID for that:

flow_log_cloudwatch_log_group_name_suffix = "test"

Screen Shot 2022-10-15 at 10 14 05

Motivation and Context

It is related to the [Feature Request] Ability to specify CloudWatch Log group name for VPC Flow logs(#836)

Breaking Changes

No breaking changes

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@antonbabenko antonbabenko changed the title feat: Ability to specify CloudWatch Log group name for VPC Flow logs feat: Added ability to specify CloudWatch Log group name for VPC Flow logs Oct 21, 2022
@antonbabenko antonbabenko merged commit 80d6318 into terraform-aws-modules:master Oct 21, 2022
antonbabenko pushed a commit that referenced this pull request Oct 21, 2022
## [3.18.0](v3.17.0...v3.18.0) (2022-10-21)

### Features

* Added ability to specify CloudWatch Log group name for VPC Flow logs ([#847](#847)) ([80d6318](80d6318))
@antonbabenko
Copy link
Member

This PR is included in version 3.18.0 🎉

@air3ijai air3ijai deleted the patch-3 branch October 21, 2022 14:09
spr-mweber3 pushed a commit to spring-media/terraform-aws-vpc that referenced this pull request Oct 28, 2022
spr-mweber3 pushed a commit to spring-media/terraform-aws-vpc that referenced this pull request Oct 28, 2022
## [3.18.0](terraform-aws-modules/terraform-aws-vpc@v3.17.0...v3.18.0) (2022-10-21)

### Features

* Added ability to specify CloudWatch Log group name for VPC Flow logs ([terraform-aws-modules#847](terraform-aws-modules#847)) ([80d6318](terraform-aws-modules@80d6318))
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants