Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update CI configuration files to use latest version #850

Merged

Conversation

bryantbiggs
Copy link
Member

Description

  • Update GitHub action versions to use latest. This remove warnings related to https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
  • Ensure pre-commit config is aligned with latest
  • Add lock.yml workflow to automatically lock issues and PRs after 30 days. Theres a lot "Me too" or "I have this issue, when will this get fixed" on really old/stale issues and in order to properly triage, users need to supply their configurations. This workflow is pulled from the AWS provider's repo to force users to fill out a proper issue ticket and keep chatter out of merged PRs or old issues

Motivation and Context

  • Patch warnings on CI checks to keep output clean
  • Focus on new issues and PRs

Breaking Changes

  • No

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

Copy link
Member

@antonbabenko antonbabenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lock Threads looks useful!

@antonbabenko antonbabenko merged commit b94561d into terraform-aws-modules:master Oct 27, 2022
antonbabenko pushed a commit that referenced this pull request Oct 27, 2022
### [3.18.1](v3.18.0...v3.18.1) (2022-10-27)

### Bug Fixes

* Update CI configuration files to use latest version ([#850](#850)) ([b94561d](b94561d))
@antonbabenko
Copy link
Member

This PR is included in version 3.18.1 🎉

spr-mweber3 pushed a commit to spring-media/terraform-aws-vpc that referenced this pull request Oct 28, 2022
spr-mweber3 pushed a commit to spring-media/terraform-aws-vpc that referenced this pull request Oct 28, 2022
@bryantbiggs bryantbiggs deleted the chore/update-ci branch November 7, 2022 19:15
@github-actions
Copy link

github-actions bot commented Dec 8, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants