Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add dns64 routes #924

Merged
merged 2 commits into from
May 15, 2023

Conversation

mikesplain
Copy link
Contributor

Description

Based on the nat64/dns64 docs, a route is required to utilize dns64 & nat64 for IPv6 only services to non-IPv6 services.

  • Add private subnet route for dns64.
  • Add database subnet route for dns64.
  • Enable nat gateway in dualstack example to test.

Motivation and Context

Fixes #923

Breaking Changes

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

I tested this both in our internal stack and against the ipv6-dualstack example. New route should be created as long as nat gateways are enabled other criteria you'll see in the PR.

I only updated private subnet route tables and database subnet route tables since it seemed to fit the existing patterns but if I missed anything or you feel differently, I'm open to any suggestions. Thanks!

@mikesplain mikesplain changed the title Add dns64 route fix: Add dns64 routes Apr 13, 2023
@github-actions
Copy link

This PR has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this PR will be closed in 10 days

@github-actions github-actions bot added the stale label May 14, 2023
@mikesplainsonos
Copy link

@bryantbiggs Mind taking a look at this PR when you have a moment? Thanks!

@bryantbiggs bryantbiggs merged commit 743798d into terraform-aws-modules:master May 15, 2023
antonbabenko pushed a commit that referenced this pull request May 15, 2023
### [4.0.2](v4.0.1...v4.0.2) (2023-05-15)

### Bug Fixes

* Add dns64 routes ([#924](#924)) ([743798d](743798d))
@antonbabenko
Copy link
Member

This PR is included in version 4.0.2 🎉

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dns64 now default without nat64 rule
4 participants