fix: Add dns64 routes #924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR has been automatically marked as stale because it has been open 30 days |
|
@bryantbiggs Mind taking a look at this PR when you have a moment? Thanks! |
bryantbiggs
approved these changes
May 15, 2023
antonbabenko
pushed a commit
that referenced
this pull request
May 15, 2023
### [4.0.2](v4.0.1...v4.0.2) (2023-05-15) ### Bug Fixes * Add dns64 routes ([#924](#924)) ([743798d](743798d))
|
This PR is included in version 4.0.2 🎉 |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Based on the nat64/dns64 docs, a route is required to utilize dns64 & nat64 for IPv6 only services to non-IPv6 services.
Motivation and Context
Fixes #923
Breaking Changes
How Has This Been Tested?
examples/*to demonstrate and validate my change(s)examples/*projectspre-commit run -aon my pull requestI tested this both in our internal stack and against the ipv6-dualstack example. New route should be created as long as nat gateways are enabled other criteria you'll see in the PR.
I only updated private subnet route tables and database subnet route tables since it seemed to fit the existing patterns but if I missed anything or you feel differently, I'm open to any suggestions. Thanks!