feat: Add support for materialized_view #139
Conversation
|
Thanks for the PR! 🚀 |
|
Hm, I'm not quite sure what to do about the CLA checks for the Some help would be appreciated here. I'm happy to make any necessary changes. |
|
@mwallace582 You need to rebase or somehow fix the email. http://treeindev.net/article/git-change-commit-name |
Add trailing whitespace Fix location of materialized_view Switch to lookup to prevent materialized_view from being requiired Fix missing comma tf_fmt Fix default value Generate Docs Update tests tf_fmt
|
Thank you for the help @morgante! I believe that this is ready to go now. I'd be happy to make any changes necessary if that's not the case. |
There was a problem hiding this comment.
Thanks for working on this! I think we could actually improve clarity here by separating out from tables. Even though the underlying implementation uses tables, they're conceptually different.
I suggest we add a new materialized_views variable (at the top level) and create the resources in a similar way to how we do the views variable today.
* Move materialized_views into a variable * Clean up file with bad line-endings
|
Also need to regenerate docs. This comment keeps up to date: #139 (comment) |
Hi Everyone,
I've been really enjoying these opinionated terraform modules from Google, thank you for maintaining them!
I just discovered that materialized views were not supported by this module while refactoring some code, and saw an open pull request. I figured I could help by performing the requested rebase.
Please let me know if this separate pull request is not an appropriate way to get this work merged. I definitely don't want to take credit for the work that @jogoldberg has done here.
Thanks!
Matthew