Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the possibility to define different lifecycle rules for each bucket #169

Merged
merged 1 commit into from
Sep 12, 2022
Merged

Add the possibility to define different lifecycle rules for each bucket #169

merged 1 commit into from
Sep 12, 2022

Conversation

AlexisBRENON
Copy link
Contributor

Fixes #110

@AlexisBRENON AlexisBRENON force-pushed the bucket_lifecycle_rules branch from e804a9e to 5aa33f0 Compare May 18, 2022 13:01
bharathkkb
bharathkkb reviewed May 19, 2022
View reviewed changes
Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @AlexisBRENON

variables.tf Outdated Show resolved Hide resolved
test/integration/multiple_buckets/multiple_buckets_test.go Show resolved Hide resolved
@AlexisBRENON AlexisBRENON requested a review from bharathkkb May 27, 2022 19:02
@AlexisBRENON
Copy link
Contributor Author

@bharathkkb I updated the PR with all the requested changes.
Can you re-review it ? Thanks.

@apeabody
Copy link
Contributor

/gcbrun

@github-actions
Copy link

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days

@github-actions github-actions bot added the Stale label Sep 11, 2022
@AlexisBRENON
Copy link
Contributor Author

Waiting for review

@comment-bot-dev
Copy link

@AlexisBRENON
Thanks for the PR! 🚀
✅ Lint checks have passed.

bharathkkb
bharathkkb approved these changes Sep 12, 2022
View reviewed changes
Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay!

@bharathkkb bharathkkb merged commit 4793dd2 into terraform-google-modules:master Sep 12, 2022
@release-please release-please bot mentioned this pull request Sep 12, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bharathkkb bharathkkb bharathkkb approved these changes

Assignees
No one assigned
Labels
Stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Lifecycle rules applied to specific buckets
4 participants
@AlexisBRENON @apeabody @comment-bot-dev @bharathkkb