Add option to enable default_event_based_hold argument

[nandagirin]

Hi, in this PR I propose to have an option to set the argument default_event_based_hold with default value set to false. This will be useful for us who use this GCS Terraform module and have the requirement to enable object holds 😃

[google-cla]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

[nandagirin]

It seems the check run terraform-google-cloud-storage-int-pull-requests is failing. I don't have the access to see the Cloud Build logs. Are there some ways for me to find out the issues? So, I could try fixing it and push new commit

[comment-bot-dev]

@nandagirin
Thanks for the PR! 🚀
✅ Lint checks have passed.

[nandagirin]

It seems the check run terraform-google-cloud-storage-int-pull-requests is failing. I don't have the access to see the Cloud Build logs. Are there some ways for me to find out the issues? So, I could try fixing it and push new commit

The previous check was failed because the example bucket two was set with object event hold enabled. The bucket was failed to be destroyed during the test cleanup since it had folder objects dev and prod already provisioned with the module with object hold enabled. This state prevented the objects to be destroyed as stated in the log file while executing the integration test locally.

module.cloud_storage.google_storage_bucket_object.folders["two_dev"]: Destroying... [id=multiple-buckets-0n7r-eu-two-dev/]
module.cloud_storage.google_storage_bucket_object.folders["two_prod"]: Destroying... [id=multiple-buckets-0n7r-eu-two-prod/]
       ╷
       │ Error: Error deleting contents of object prod/: googleapi: Error 403: Object 'multiple-buckets-0n7r-eu-two/prod/' is under active Event-Based hold and cannot be deleted, overwritten or archived until hold is removed., forbidden
       │
       │
       ╵
       ╷
       │ Error: Error deleting contents of object dev/: googleapi: Error 403: Object 'multiple-buckets-0n7r-eu-two/dev/' is under active Event-Based hold and cannot be deleted, overwritten or archived until hold is removed., forbidden
       │
       │
       ╵

So, I changed the bucket with event hold enabled to bucket one in the example in this commit. Since bucket one does not have objects yet, it could be destroyed safely during the integration test.

Please review this PR ya 😃

[bharathkkb]

Thanks for the PR @nandagirin