Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add kubectl-fleet-wrapper sub-module #161

Merged
merged 5 commits into from
Sep 25, 2023
Merged

feat: add kubectl-fleet-wrapper sub-module #161

merged 5 commits into from
Sep 25, 2023

Conversation

apeabody
Copy link
Contributor

@apeabody apeabody commented Sep 12, 2023 •
edited
Loading

Fixes: #162

@apeabody apeabody requested a review from a team as a code owner September 12, 2023 23:56
@apeabody apeabody force-pushed the ap-asdf3 branch 2 times, most recently from c48e29b to 8705e1c Compare September 13, 2023 01:25
bharathkkb
bharathkkb previously approved these changes Sep 13, 2023
View reviewed changes
@apeabody apeabody changed the title fix: pass use connect as bool DO NOT MERGE: pass use connect as bool Sep 13, 2023
@apeabody apeabody marked this pull request as draft September 13, 2023 03:37
@apeabody apeabody force-pushed the ap-asdf3 branch 3 times, most recently from 2bef8ea to 7bab2a0 Compare September 17, 2023 00:12
@apeabody apeabody changed the title DO NOT MERGE: pass use connect as bool DO NOT MERGE!: add use_connect_gateway and remove use_existing_context Sep 17, 2023
@apeabody apeabody force-pushed the ap-asdf3 branch 9 times, most recently from 6ca03d0 to 9bb5885 Compare September 17, 2023 16:14
@apeabody apeabody changed the title DO NOT MERGE!: add use_connect_gateway and remove use_existing_context feat!: add use_connect_gateway and remove use_existing_context Sep 18, 2023
@g-awmalik
Copy link
Contributor

Should we just do a separate module for fleets?

@apeabody apeabody changed the title feat!: add use_connect_gateway and remove use_existing_context feat: add kubectl-fleet-wrapper sub-module Sep 20, 2023
@apeabody apeabody force-pushed the ap-asdf3 branch 4 times, most recently from b20cd42 to 48fcf45 Compare September 20, 2023 19:42
@apeabody apeabody force-pushed the ap-asdf3 branch 6 times, most recently from d7f4240 to 83f1d4d Compare September 21, 2023 00:53
@apeabody
Copy link
Contributor Author

Made use of the updated fleet-membership sub-module: https://github.com/terraform-google-modules/terraform-google-gcloud/pull/161/files#diff-74cf274c635eacce689779adfe1b714da7fb5beabcfbb6d686b2753ad0cc1e69R123

@apeabody apeabody marked this pull request as ready for review September 21, 2023 15:19
g-awmalik
g-awmalik reviewed Sep 25, 2023
View reviewed changes
modules/kubectl-fleet-wrapper/README.md Outdated Show resolved Hide resolved
modules/kubectl-fleet-wrapper/README.md Outdated Show resolved Hide resolved
apeabody and others added 2 commits September 25, 2023 12:06
@apeabody @g-awmalik
Update modules/kubectl-fleet-wrapper/README.md
f5c9031 
Co-authored-by: Awais Malik <awmalik@google.com>
@apeabody @g-awmalik
Update modules/kubectl-fleet-wrapper/README.md
fa7902d 
Co-authored-by: Awais Malik <awmalik@google.com>
@apeabody apeabody merged commit bc4076c into master Sep 25, 2023
6 checks passed
@apeabody apeabody deleted the ap-asdf3 branch September 25, 2023 21:07
@release-please release-please bot mentioned this pull request Sep 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bharathkkb bharathkkb bharathkkb left review comments

@g-awmalik g-awmalik g-awmalik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

use_connect_gateway: true drops memberships from cmd
3 participants
@apeabody @g-awmalik @bharathkkb