Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

additional_components will trigger when only 1 component in list #43

Merged
merged 1 commit into from
May 9, 2020
Merged

additional_components will trigger when only 1 component in list #43

merged 1 commit into from
May 9, 2020

Conversation

estecker
Copy link
Contributor

@estecker estecker commented May 8, 2020

additional_components resource would not be used if length(var.additional_components) == 1. This is a fix for that.

@estecker
additional_components trigger when additional_components == 1
9d63792 
additional_components resource would not be used if length(var.additional_components) == 1. This is a fix for that.
@bharathkkb
Copy link
Member

We use a single additional_components in our GKE module and I was wondering how that worked but turns out we had the kubectl binary in our tools image and that masked this.

@morgante morgante merged commit 25b97e3 into terraform-google-modules:master May 9, 2020
@estecker estecker deleted the patch-1 branch May 9, 2020 13:49
morgante pushed a commit that referenced this pull request Jul 10, 2020
@estecker
fix: Download additional_components when var.additional_components ==…
9af0423 
… 1 (#43)

additional_components resource would not be used if length(var.additional_components) == 1. This is a fix for that.

Former-commit-id: 25b97e3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@morgante morgante morgante approved these changes

@bharathkkb bharathkkb bharathkkb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@estecker @bharathkkb @morgante