Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Lazy eval data source only if enabled #76

Merged
merged 3 commits into from
Sep 2, 2020
Merged

fix: Lazy eval data source only if enabled #76

merged 3 commits into from
Sep 2, 2020

Conversation

bharathkkb
Copy link
Member

No description provided.

@bharathkkb bharathkkb changed the title Lazy eval data source only if enabled fix: Lazy eval data source only if enabled Sep 2, 2020
@comment-bot-dev
Copy link

comment-bot-dev commented Sep 2, 2020 •
edited
Loading

Thanks for the PR! 🚀
✅ Lint checks have passed.

@bharathkkb bharathkkb mentioned this pull request Sep 2, 2020
Merged
@bharathkkb
Copy link
Member Author

@morgante Previously #73 did not fail as we never tested with enabled = false. I have added another test case to cover that path.

@bharathkkb bharathkkb merged commit f2c9913 into master Sep 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@morgante morgante morgante approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bharathkkb @comment-bot-dev @morgante