Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dependencies when upgrade is disabled #97

Merged
merged 1 commit into from
Aug 4, 2021

Conversation

naormatania
Copy link
Contributor

If we wish to download and install gcloud without upgrading, it fails since dependency are not aligned.
This PR fixes it

To test, check that following code succeeds after the change:

module "install_gcloud" {
  source  = "terraform-google-modules/gcloud/google"
  # version = "~> 2.0"

  platform                          = "linux"
  additional_components             = ["alpha"]
  skip_download                     = false
  gcloud_sdk_version                = "350.0.0"
  upgrade                           = false
  use_tf_google_credentials_env_var = true
}

@google-cla
Copy link

google-cla bot commented Aug 4, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@comment-bot-dev
Copy link

Thanks for the PR! 🚀
✅ Lint checks have passed.

@naormatania
Copy link
Contributor Author

@googlebot I signed it!

@morgante morgante merged commit 129b31c into terraform-google-modules:master Aug 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants