Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial Node Pool Metadata #1000

Closed
gfthybridlabs opened this issue Sep 13, 2021 · 5 comments
Closed

Initial Node Pool Metadata #1000

gfthybridlabs opened this issue Sep 13, 2021 · 5 comments
Labels
bug Something isn't working P2 high priority issues triaged Scoped and ready for work

Comments

@gfthybridlabs
Copy link

Hi,

We have policies enabled that mean we must disable serial-port-logging, enable-guest-attributes etc. I add these to the node-pool definitions:-

node_pools_metadata = {
  all = {
    serial-port-logging-enable = false
    enable-guest-attributes = false
    disable-legacy-endpoits = true
  }
}

But the default-pool that gets created still has those attached (unless I have done it wrong) so the cluster creation fails.

How can I add those to the default-pool before it gets deleted and replaced with my node pools ?

Thanks

@morgante
Copy link
Contributor

What value do you have for remove_default_node_pool?

We might need to fix the metadata here - https://github.com/terraform-google-modules/terraform-google-kubernetes-engine/blob/master/autogen/main/cluster.tf.tmpl#L250.

@gfthybridlabs
Copy link
Author

Thanks. It's set to "true"

@morgante morgante added bug Something isn't working P2 high priority issues triaged Scoped and ready for work labels Sep 13, 2021
@morgante
Copy link
Contributor

Thanks. If you're able to fix this a pull request would be appreciated.

@gfthybridlabs
Copy link
Author

I'll see if I have the skills to do that. Hard coding a "metadata = {map}" object of K/V pairs works fine so just need to expose that as a variable.

@bharathkkb
Copy link
Member

fixed by #1018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working P2 high priority issues triaged Scoped and ready for work
Projects
None yet
Development

No branches or pull requests

3 participants