-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add support for gVisor per node pool #1001
feat: Add support for gVisor per node pool #1001
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
Thanks for the PR! 🚀 |
@LukaszCzarnotaSabre Looks like this change is causing test failures:
Could you please update tests to make sure they're compliant with this change? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! It would also be great to add this to one of our tests to make sure its WAI
0b1deaf
to
4d1f5ba
Compare
4d1f5ba
to
40c4233
Compare
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
@googlebot I consent. |
/cc @morgante for another pass since I have a commit in here |
* feat: Add support for gVisor per node pool * fix image type, add test Co-authored-by: Bharath KKB <bharathkrishnakb@gmail.com>
…1001) * feat: Add support for gVisor per node pool * fix image type, add test Co-authored-by: Bharath KKB <bharathkrishnakb@gmail.com>
Issue https://github.com/terraform-google-modules/terraform-google-kubernetes-engine/issues/240 was resolved but now all node pools needs to be with gVisor or non of them.
With this PR you are able to define
sandbox_enabled
variable per node pool, code is backward compatible.