Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: WI GCP SA output #1009

Merged
merged 3 commits into from
Sep 28, 2021
Merged

fix: WI GCP SA output #1009

merged 3 commits into from
Sep 28, 2021

Conversation

bharathkkb
Copy link
Member

fixes #1006

@bharathkkb bharathkkb requested review from Jberlinsky and a team as code owners September 27, 2021 23:32
@morgante
Copy link
Contributor

@bharathkkb We should also consider adding a test to verify this value is non-null.

@comment-bot-dev
Copy link

comment-bot-dev commented Sep 27, 2021 •
edited
Loading

Thanks for the PR! 🚀
✅ Lint checks have passed.

@bharathkkb
Copy link
Member Author

@morgante swapped one of the example outputs to get value from this op instead

@bharathkkb bharathkkb merged commit b431aa5 into master Sep 28, 2021
@bharathkkb bharathkkb deleted the bharathkkb-patch-2 branch September 28, 2021 03:44
CPL-markus pushed a commit to WALTER-GROUP/terraform-google-kubernetes-engine that referenced this pull request Jul 15, 2024
@bharathkkb
fix: WI GCP SA output (terraform-google-modules#1009)
f6c3fd9 
* fix: WI GCP SA output

* exercise op in example
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@morgante morgante morgante approved these changes

@Jberlinsky Jberlinsky Awaiting requested review from Jberlinsky

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Workload identity gcp_service_account return value incorrect in 16.1.0
3 participants
@bharathkkb @morgante @comment-bot-dev